[DUOS-2898] Switch more hyperscript-helpers to JSX #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
force-pushed
the
fb-duos-2898-hyperscript-to-jsx
branch
from
461a486 to
5daddbc
Compare
rushtong
reviewed
Feb 28, 2024
| aria-haspopup="true" | ||
| aria-expanded="false" | ||
| onClick={onOpen} | ||
| disabled={disabled} |
There was a problem hiding this comment.
It looks like this attribute is not allowed here (and indeed, there are other non-standard attributes scattered across the older hyperscript), but I favor keeping this (and others) here to lessen the potential for regressions.
rushtong
reviewed
Feb 28, 2024
| <div className='data-update-section'> | ||
| <h2>1. Dataset Information</h2> | ||
| <FormField | ||
| id="datasetName" |
There was a problem hiding this comment.
I'm curious about the double quotes not triggering our eslint rule:
"quotes": ["warn", "single", {"avoidEscape": true, "allowTemplateLiterals": true}], // Checks for single quote usage where possible
Not critical for this PR, but we should investigate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2898
Summary
Follow up to #2397 and #2438 . Switches more components from
react-hyperscript-helpersto JSX.Note: now that we are getting down to the last set of components, some of the code requires functional changes to work. Please test these out.
Have you read Terra's Contributing Guide lately? If not, do that first.